Skip to content

Conversation

CarolynRountree
Copy link
Contributor

Discover custom MBean attributes. Right now for specifically discovering Security Provider MBeans. Add custom conversion routine for discovered values.

Tested with added unit test and discovering IDCS domain in offline and online.

@CarolynRountree
Copy link
Contributor Author

discovered

ddsharpe
ddsharpe previously approved these changes Aug 9, 2019
Copy link
Member

@ddsharpe ddsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rakillen rakillen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few typos, etc.

@ddsharpe ddsharpe merged commit 7e4527b into master Aug 12, 2019
@ddsharpe ddsharpe deleted the WDT-247#-discover-custom-security-mbean branch August 12, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants