Skip to content

Convert error prone string comparisons to shell script conditional #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2019
Merged

Convert error prone string comparisons to shell script conditional #419

merged 1 commit into from
Aug 15, 2019

Conversation

ddsharpe
Copy link
Member

Replaced unix shell script string comparisons with -z (or -n) conditional tests

jshum2479
jshum2479 approved these changes Aug 15, 2019
View reviewed changes
Copy link
Member

@jshum2479 jshum2479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to refactor the scripts into some reusable units instead of duplicating them

@ddsharpe ddsharpe merged commit 49bc808 into master Aug 15, 2019
@ddsharpe ddsharpe deleted the shell-script-equals branch August 15, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshum2479 jshum2479 jshum2479 approved these changes

@rakillen rakillen rakillen approved these changes

+1 more reviewer

@CarolynRountree CarolynRountree CarolynRountree approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ddsharpe @jshum2479 @rakillen @CarolynRountree