Opsscli #440
Merged
Opsscli #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakillen
reviewed
Sep 11, 2019
| if opss_wallet is not None and opss_secret_password is not None: | ||
| self.wlst_helper.setSharedSecretStoreWithPassword(opss_wallet, opss_secret_password) | ||
|
|
||
| self.logger.exiting(class_name=self.__class_name, method_name=_method_name) |
There was a problem hiding this comment.
Exiting log should be same indent level as return, I think?
There was a problem hiding this comment.
Yes. I have refactored the code and corrected the spelling in message catalog
| @@ -1175,5 +1175,11 @@ def __configure_opss_secrets(self): | |||
| zip_entry = archive_file.getOPSSWallet(); | |||
| FileUtils.extractZipFileContent(archive_file, zip_entry, extract_path) | |||
| self.wlst_helper.setSharedSecretStoreWithPassword(extract_path, opss_secret_password) | |||
| self.logger.exiting(class_name=self.__class_name, method_name=_method_name) | |||
| return extract_path | |||
| else: | |||
There was a problem hiding this comment.
Hard to tell from this diff, but it looks like this "else" is for "if OPSS_SECRETS in domain_info", still inside "if domain_info is not None". Seems like it should be:
if (domain_info is not None) and (OPSS_SECRETS in domain_info):
... use values from domain info
else:
... check model context
Even though the domain_info section should always be present on a create.
| @@ -1442,6 +1442,8 @@ WLSDPLY-20023={0} unable to add model file {1} to archive as {2}: {3} | |||
| WLSDPLY-20024={0} failed to persist the model to the archive file {1}: {2} | |||
| WLSDPLY-20025=For {0}, specify the {1} or {2} argument, but not both | |||
| WLSDPLY-20026={0} failed to find a model file in archive {1}, and {2} argument not specified | |||
| WLSDPLY-20027=Enter the opss wallet passphrase | |||
| WLSDPLY-20028=Failed to read the opss wallet passphrase input from the user: {0} | |||
rakillen
approved these changes
Sep 12, 2019
ddsharpe
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add opss wallet import command line options for sharing DB use case
-opss_wallet
-opss_wallet_passphrase