-
Notifications
You must be signed in to change notification settings - Fork 91
Wdt automate tokenize credentials #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…/weblogic-deploy-tooling into WDT-automate-tokenize-credentials
This reverts commit e18a66b.
core/src/main/resources/oracle/weblogic/deploy/messages/wlsdeploy_rb.properties
Outdated
Show resolved
Hide resolved
Additionally addresses Issue #446.
…/weblogic-deploy-tooling into WDT-automate-tokenize-credentials
the default variable file, model.properties, is zeroed out even if I do not put the -variable_file argument on the command line |
These properties for the datasources are really long. Is it hard to shorten them? Suggested alternatives: |
One algorithm I can think of is to replace every MBean/Name pair, with Name, and remove each singleton MBean, except for the last one. So that the long name above becomes |
…/weblogic-deploy-tooling into WDT-automate-tokenize-credentials
@@ -197,5 +197,30 @@ def testDictOrderedDictUpdate(self): | |||
self.assertEqual('entry1' in dict1 and 'entry2' in dict1, True, | |||
"expected ordereddict1 to contain 'entry1' and 'entry2' keys") | |||
|
|||
# def testOrderedDictSort(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did DS add this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought PyOrderedDict had a problem. This test exposed an issue with my own logic, so I asked him to add it permanently. It's a simple to test to sort a dictionary by keys, and add the items to the dictionary in this sorted order. The PyOrderedDict simply cares about the order you add them, but its a good example of how to sort a dictionary with our OrderedDict
def __format_variable_name(self, location, attribute): | ||
_method_name = '__format_variable_name' | ||
def get_folder_short_name(self, folder_name): | ||
_method_name = '_match_short_top_folder' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method name is 'get_folder_short_name'
discoverDomain changed to automatically replace password attribute values with a property token, and the property written a specified variable file IF the -variable_file argument is included on the command line.
This will work in conjunction with any variable injector directives the user specifies.