Skip to content

Parser fixes #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 21, 2020
Merged

Parser fixes #524

merged 11 commits into from
Jan 21, 2020

Conversation

rakillen
Copy link
Member

@rakillen rakillen commented Jan 18, 2020 •
edited
Loading

Fix several problems with YAML parsing:

  • blank lines and comments at the top of the file
  • empty comment lines like #
  • comments after object block open, like domainInfo: # mine
  • single-line comments throwing off indentation

See new model comment-model.yaml for examples

Broke out YamlJavaTranslator for use in multiple unit tests.

Fixed compiler warning in LoggingUtils.

Fixes #236

@rakillen rakillen changed the title Parser tests Parser fixes Jan 18, 2020
@ddsharpe ddsharpe merged commit 12b64ca into master Jan 21, 2020
@ddsharpe ddsharpe deleted the parser-tests branch January 21, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddsharpe ddsharpe ddsharpe approved these changes

@CarolynRountree CarolynRountree CarolynRountree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't have blank lines in model yaml files
3 participants
@rakillen @ddsharpe @CarolynRountree