Skip to content

Issue #585 Improve error messages for token syntax errors #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2020
Merged

Issue #585 Improve error messages for token syntax errors #586

merged 2 commits into from
Apr 6, 2020

Conversation

rakillen
Copy link
Member

@rakillen rakillen commented Apr 6, 2020 •
edited
Loading

Fixes #585

Revised message examples:

<WLSDPLY-01746> <Invalid token syntax for ProductionModeEnabled value "@@PROP: ProductionModeEnabled@@", should match "@@PROP:<name>@@">

<WLSDPLY-01745> <Invalid token syntax for name "@@PROP: my-cluster", should match "@@PROP:<name>@@"

@rakillen rakillen changed the title Issue #585 Improve error messsages for token syntax errors Issue #585 Improve error messages for token syntax errors Apr 6, 2020
@ddsharpe ddsharpe merged commit 7e3d3d2 into master Apr 6, 2020
@ddsharpe ddsharpe deleted the issue#585-improve-token-syntax-message branch April 6, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddsharpe ddsharpe ddsharpe approved these changes

+1 more reviewer

@CarolynRountree CarolynRountree CarolynRountree approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error reporting for token syntax errors
3 participants
@rakillen @ddsharpe @CarolynRountree