-
Notifications
You must be signed in to change notification settings - Fork 91
Issue#633 determining when to perform opss db #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ddsharpe
merged 27 commits into
master
from
Issue#633-determining-when-to-perform-opss-db
May 26, 2020
Merged
Issue#633 determining when to perform opss db #635
ddsharpe
merged 27 commits into
master
from
Issue#633-determining-when-to-perform-opss-db
May 26, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakillen
approved these changes
May 22, 2020
ddsharpe
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A check was added to only run opss db defaults if it was a jrf domain. I believe previously there just had to be an extension template. The test for JRF was not broad enough for the user's typedef file. Expanded the check. Hopefully this will be broad enough for these extended typedefs. Fixes #633