Skip to content

Revise documents to show model sample output #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2020
Merged

Revise documents to show model sample output #675

merged 2 commits into from
Jul 27, 2020

Conversation

rakillen
Copy link
Member

Internal JIRA WDT-435

@rakillen rakillen added the hold for next release Don't merge this until next release, it has README content label Jul 10, 2020
ddsharpe
ddsharpe reviewed Jul 14, 2020
View reviewed changes
Copy link
Member

@ddsharpe ddsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should call out that the -model_sample option is deprecated (in the docs, not just the CLA)

@ddsharpe ddsharpe merged commit 9812d22 into master Jul 27, 2020
@ddsharpe ddsharpe deleted the JIRA-WDT-435-model-help-docs branch July 27, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddsharpe ddsharpe ddsharpe approved these changes

+1 more reviewer

@CarolynRountree CarolynRountree CarolynRountree approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
hold for next release Don't merge this until next release, it has README content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rakillen @ddsharpe @CarolynRountree