Allow discover to run without required archive file #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakillen
approved these changes
Feb 1, 2021
rakillen
reviewed
Feb 1, 2021
ddsharpe
approved these changes
Feb 1, 2021
| validateExistingFile(model, "model", getArchiveFileName(), METHOD); | ||
| getZipFile().removeZipEntries(ARCHIVE_MODEL_TARGET_DIR); | ||
| addItemToZip(ARCHIVE_MODEL_TARGET_DIR, model); | ||
| if (hasArchive) { |
There was a problem hiding this comment.
With a code block this small, it doesn't matter much. But, code analyzers tend to report that the quick test and return are less "complex" for the reader. Like
if (hasArchive) {
return;
}
There was a problem hiding this comment.
I would agree with that except that all of these methods have enter / exit logging
robertpatrick
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #824