Skip to content

For -target vz and wko, omit cluster section if list is empty #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

rakillen
Copy link
Member

@rakillen rakillen commented Feb 17, 2021

Problems discussed in verrazzano-dev Slack:

  • Section clusters should be omitted if list is empty.
  • A control character was removed from application.yaml .

For template processing, skip template block if false value in hash.
Internal Jira WDT-522

@@ -1,6 +1,6 @@
# Copyright (c) 2020, 2021, Oracle and/or its affiliates.
# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't show in review, but removing <200b> control character on this line.

@rakillen rakillen changed the title For -target vz and wko, skip template block if false value in hash For -target vz and wko, omit cluster section if list is empty Feb 17, 2021
@ddsharpe ddsharpe merged commit 495bb27 into master Feb 18, 2021
@ddsharpe ddsharpe deleted the JIRA-WDT-522-fix-empty-block-check branch February 18, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants