Skip to content

Conversation

lennyphan
Copy link
Member

To support generating configuration overrides with model filtering , for Model-In-Image (MII) domain home source type, the following changes are needed in WDT:

  1. Add the ability to apply filters for The Validate Model Tool (validateModel),
  2. Persist model after filtering has been applied.

For MII, validateModel tool is used to generate merged models and filtering is needed to apply configuration overrides.

A couple unit tests created to verify that model filter(s) are invoked (for validateModel tool) and to verify that filter changes are persisted, if configured.

Copy link
Member

@jshum2479 jshum2479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rakillen rakillen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the model should still have variables unresolved before going into validate_in_standalone_mode, so that any missing variables can be logged there.

@ddsharpe ddsharpe merged commit 1d51846 into master Mar 17, 2021
@ddsharpe ddsharpe deleted the filtering-on-validate branch March 17, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants