Provide options for specifying inventory file and location #103 #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddsharpe
requested changes
Nov 12, 2019
|
|
||
| @Option( | ||
| names = {"--inventoryPointerInstallLoc"}, | ||
| description = "path to a inventory location file. Override the default inventory location file" |
There was a problem hiding this comment.
The description of both of these parameters is exactly the same. How does the user differentiate what to put in each parameter?
|
|
||
| if (inventoryPointerInstallLoc != null) { | ||
| List<String> invLocValue = new ArrayList<>(2); | ||
| invLocValue.add(Constants.BUILD_ARG); |
There was a problem hiding this comment.
Please use mustache place-holders instead of build-args.
There was a problem hiding this comment.
merged master into it. Please review
ddsharpe
requested changes
Dec 2, 2019
| } | ||
| } | ||
| } catch (FileNotFoundException notFound) { | ||
| logger.severe("Unable to find installer response file: {0}", inventoryLoc); |
There was a problem hiding this comment.
needs i18n. move message to resource bundle
|
|
||
| @Option( | ||
| names = {"--inventoryPointerInstallLoc"}, | ||
| description = "path to where the inventory pointer file (oraInst.loc) should be store in the image" |
imagetool/src/main/resources/docker-files/Create_Image.mustache
Outdated
Show resolved
Hide resolved
imagetool/src/main/resources/docker-files/Create_Image.mustache
Outdated
Show resolved
Hide resolved
… and error message
# Conflicts: # imagetool/src/main/resources/docker-files/Create_Image.mustache
ddsharpe
approved these changes
Dec 16, 2019
rjeberhard
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.