Skip to content

Updated documentation for release 1.8.2 #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 23, 2020
Merged

Updated documentation for release 1.8.2 #145

merged 6 commits into from
Mar 23, 2020

Conversation

ddsharpe
Copy link
Member

@ddsharpe ddsharpe commented Mar 9, 2020

--buildNetwork for Docker --network
and
--wdtEncryptionKey for WDT -use_encryption

mriccell
mriccell previously approved these changes Mar 9, 2020
Copy link
Member

@rosemarymarano rosemarymarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor edits.

@@ -33,6 +34,9 @@ Usage: imagetool create [OPTIONS]
| `--wdtArchive` | Path to the WDT archive file used by the WDT model. | |
| `--wdtDomainHome` | Path to the `-domain_home` for WDT. | |
| `--wdtDomainType` | WDT domain type. Supported values: `WLS`, `JRF`, `RestrictedJRF` | `WLS` |
| `--wdtEncryptionKey` | Passphrase for WDT -use_encryption, that will be requested on STDIN. | |
| `--wdtEncryptionKeyEnv` | Passphrase for WDT -use_encryption, that is provided as an environment variable. | |
| `--wdtEncryptionKeyFile` | Passphrase for WDT -use_encryption, that is provided as a file. | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-use_encryption, that -> -use_encryption that (remove the comma after -use_encryption in all three descriptions.)

@@ -44,6 +45,9 @@ Update WebLogic Docker image with selected patches
| `--wdtArchive` | Path to the WDT archive file used by the WDT model. | |
| `--wdtDomainHome` | Path to the `-domain_home` for WDT. | |
| `--wdtDomainType` | WDT domain type. Supported values: `WLS`, `JRF`, `RestrictedJRF` | `WLS` |
| `--wdtEncryptionKey` | Passphrase for WDT -use_encryption, that will be requested on STDIN. | |
| `--wdtEncryptionKeyEnv` | Passphrase for WDT -use_encryption, that is provided as an environment variable. | |
| `--wdtEncryptionKeyFile` | Passphrase for WDT -use_encryption, that is provided as a file. | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-use_encryption, that -> -use_encryption that (remove the comma after -use_encryption in all three descriptions.)

@@ -10,6 +10,7 @@ Usage: imagetool create [OPTIONS]
| --- | --- | --- |
| `--additionalBuildCommands` | Path to a file with additional build commands. For more details, see [Additional information](#additional-information). |
| `--additionalBuildFiles` | Additional files that are required by your `additionalBuildCommands`. A comma separated list of files that should be copied to the build context. |
| `--buildNetwork` | Networking mode for the RUN instructions during the image build. See Docker --network. | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Docker --network is an attribute of a Docker command, it should be written as docker --network (if docker is part of the command) or Docker --network (if network if it is an attribute of some other Docker command).

@@ -12,6 +12,7 @@ Usage: imagetool rebase [OPTIONS]
| --- | --- | --- |
| `--additionalBuildCommands` | Path to a file with additional build commands. For more details, see [Additional information](#additional-information). |
| `--additionalBuildFiles` | Additional files that are required by your `additionalBuildCommands`. A comma separated list of files that should be copied to the build context. |
| `--buildNetwork` | Networking mode for the RUN instructions during the image build. See Docker --network. | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Docker --network is an attribute of a Docker command, it should be written as docker --network (if docker is part of the command) or Docker --network (if network if it is an attribute of some other Docker command).

@@ -25,6 +25,7 @@ Update WebLogic Docker image with selected patches
| --- | --- | --- |
| `--additionalBuildCommands` | Path to a file with additional build commands. For more details, see [Additional information](#additional-information). |
| `--additionalBuildFiles` | Additional files that are required by your `additionalBuildCommands`. A comma separated list of files that should be copied to the build context. |
| `--buildNetwork` | Networking mode for the RUN instructions during the image build. See Docker --network. | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Docker --network is an attribute of a Docker command, it should be written as docker --network (if docker is part of the command) or Docker --network (if network if it is an attribute of some other Docker command).

@ddsharpe ddsharpe merged commit 4427b7e into master Mar 23, 2020
@ddsharpe ddsharpe deleted the doc-updates branch March 23, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants