Support for Ansi colors in console logger #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddsharpe
requested review from
mriccell,
jshum2479,
rjeberhard,
rakillen and
CarolynRountree
jshum2479
approved these changes
Jun 15, 2020
CarolynRountree
suggested changes
Jun 15, 2020
| } else { | ||
| // check logging properties to see if the user wants to disable color output | ||
| String flag = LogManager.getLogManager().getProperty("java.util.logging.ConsoleHandler.color"); | ||
| if (flag != null && flag.equalsIgnoreCase("false")) { |
There was a problem hiding this comment.
Why not just put the property on your ConsoleFormatter?
There was a problem hiding this comment.
no reason, other than to simplify the interface for the user. The user only knows about the ConsoleHandler (within the logging.properties file), and the formatter is injected into all ConsoleHandlers. The Handler seemed like the right place for the setting.
| } | ||
|
|
||
| private String replaceColorTokens(String text) { | ||
| //Pattern pattern = Pattern.compile("\\[([a-z]+)\\]"); |
There was a problem hiding this comment.
remove commented line.
Why not put this up in the class variables so it is only done once?
imagetool/src/main/java/com/oracle/weblogic/imagetool/logging/ConsoleFormatter.java
Show resolved
Hide resolved
CarolynRountree
approved these changes
Jun 15, 2020
rakillen
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding color to the console logger makes it easier to see key data in the user's console.