include recommended PSU overlay patches in --recommendedPatches #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarolynRountree
approved these changes
Dec 8, 2020
mriccell
approved these changes
Dec 9, 2020
jshum2479
reviewed
Dec 9, 2020
| @@ -67,7 +67,7 @@ Document getRecommendedPatchesMetadata(AruProduct product, String releaseNumber, | |||
| String password) throws XPathExpressionException, AruException { | |||
| Document result; | |||
| try { | |||
| if (releaseNumber.equals("336")) { | |||
| if (releaseNumber.equals("336") || releaseNumber.equals("304")) { | |||
There was a problem hiding this comment.
Maybe using an arraylist to see if releaseNumber is better for future, also any significant meaning of 336 or 304 ? Can we name it ?
There was a problem hiding this comment.
This unit test uses hard-coded release numbers in the XML under resources. We can make these values anything we want since they are simple strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommended PSU overlay patches include security fixes and should be included in the set of patches returned from --recommendedPatches. Unfortunately, ARU metadata does not include the recommended overlays unless the release requested is the PSU version, and not the GA version.