Skip to content

allow usage of Mustache placeholders in additional build command file #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2022

Conversation

ddsharpe
Copy link
Member

This change allows the usage of any existing template placeholders currently used by the build from within an additional build command file. If the user specifies --additionalBuildCommands {file}, placeholders like {{java_home}} or {{oracle_home}} within the {file} provided were not previously resolved. This change allows the usage of any of the existing placeholders used in the Image Tools templates to be used within the user's {file}.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.1% 92.1% Coverage
0.0% 0.0% Duplication

@ddsharpe ddsharpe merged commit 9b658db into main May 4, 2022
@ddsharpe ddsharpe deleted the mustache-additional-build branch May 4, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants