-
Notifications
You must be signed in to change notification settings - Fork 25
Imagetooltest1 #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imagetooltest1 #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot commit binaries like the zip file to Github. Please replace with something that builds the zip.
With all the changes recently, is this still valid for review and merge ? |
The archive.zip is removed. Please review it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. Are you cleaning up the docker images before and after? Also, it may be a good idea to cleanup wlsimgbuilder_temp*.
I will add that in the cleanup. |
the cleanup method is updated |
…into imagetooltest1
…into imagetooltest1
No description provided.