Skip to content

Imagetooltest1 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jul 9, 2019
Merged

Imagetooltest1 #36

merged 24 commits into from
Jul 9, 2019

Conversation

xiancao
Copy link
Member

@xiancao xiancao commented Jun 21, 2019

No description provided.

@xiancao xiancao requested review from ddsharpe and jshum2479 June 21, 2019 23:27
Copy link
Member

@ddsharpe ddsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot commit binaries like the zip file to Github. Please replace with something that builds the zip.

@jshum2479
Copy link
Member

With all the changes recently, is this still valid for review and merge ?

@xiancao
Copy link
Member Author

xiancao commented Jun 28, 2019

The archive.zip is removed. Please review it again.

@xiancao xiancao requested a review from ddsharpe June 28, 2019 20:24
Copy link
Member

@jshum2479 jshum2479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Are you cleaning up the docker images before and after? Also, it may be a good idea to cleanup wlsimgbuilder_temp*.

@xiancao
Copy link
Member Author

xiancao commented Jun 29, 2019

Good work. Are you cleaning up the docker images before and after? Also, it may be a good idea to cleanup wlsimgbuilder_temp*.

I will add that in the cleanup.

@xiancao
Copy link
Member Author

xiancao commented Jun 29, 2019

Good work. Are you cleaning up the docker images before and after? Also, it may be a good idea to cleanup wlsimgbuilder_temp*.

the cleanup method is updated

@xiancao xiancao merged commit eb02a09 into master Jul 9, 2019
@xiancao xiancao deleted the imagetooltest1 branch July 9, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants