Skip to content

additional build commands allow users to inject custom Docker commands #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 3, 2019

Conversation

ddsharpe
Copy link
Member

New feature, additional build commands allow users to inject custom commands into the Docker build step

Fixes #23, #78.

Copy link
Member

@jshum2479 jshum2479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an option to just print out the Dockerfile only ... so that user know what ARG, ENV is used at certain stage and provide the additional commands ?

@ddsharpe
Copy link
Member Author

Is there an option to just print out the Dockerfile only ... so that user know what ARG, ENV is used at certain stage and provide the additional commands ?

Not at the moment, no. But that would be a nice thing to add.

jshum2479
jshum2479 previously approved these changes Sep 26, 2019
@ddsharpe ddsharpe requested a review from jshum2479 October 2, 2019 19:37
@ddsharpe ddsharpe merged commit c157e55 into master Oct 3, 2019
@ddsharpe ddsharpe deleted the additional-build-commands branch October 4, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hooks to provide customized inputs
4 participants