Skip to content

Require JDK 11, Maven plugin and dependency versions #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 9, 2019
Merged

Require JDK 11, Maven plugin and dependency versions #1011

merged 11 commits into from
Apr 9, 2019

Conversation

rjeberhard
Copy link
Member

This change:

  • Requires minimum Maven (3.5.2) and JDK (11) versions
  • Updates Maven plugin dependencies
  • Updates other dependencies
  • Small number of Java code changes for JDK 11 (e.g. asm library)

@russgold
Copy link
Contributor

russgold commented Apr 8, 2019

Why the JDK11 minimum? Are we using some JDK11 features?

@rjeberhard
Copy link
Member Author

@russgold, this change doesn't use any specific JDK 11 features. Once we give people time to install JDK 11 and this PR is merged, then I'm open to using such features.

@rjeberhard
Copy link
Member Author

rjeberhard commented Apr 8, 2019 •
edited
Loading

Full suite clean: http://****/job/weblogic-kubernetes-operator-javatest/1470/

@rjeberhard rjeberhard merged commit 4c8e643 into develop Apr 9, 2019
@rjeberhard rjeberhard deleted the update-dependencies branch April 9, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@markxnelson markxnelson markxnelson approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjeberhard @russgold @markxnelson