OWLS-72193 - Operator logs repeated NPE when a domain resource credential secret is missing #1034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russgold
reviewed
Apr 17, 2019
operator/src/main/java/oracle/kubernetes/operator/http/HttpClient.java
Outdated
Show resolved
Hide resolved
russgold
reviewed
Apr 17, 2019
operator/src/main/java/oracle/kubernetes/operator/logging/LoggingFilter.java
Outdated
Show resolved
Hide resolved
russgold
reviewed
Apr 17, 2019
operator/src/main/java/oracle/kubernetes/operator/logging/OncePerMessageLoggingFilter.java
Outdated
Show resolved
Hide resolved
russgold
reviewed
Apr 17, 2019
operator/src/main/java/oracle/kubernetes/operator/steps/ReadHealthStep.java
Show resolved
Hide resolved
russgold
reviewed
Apr 17, 2019
operator/src/test/java/oracle/kubernetes/operator/logging/LoggingFacadeTest.java
Show resolved
Hide resolved
tbarnes-us
reviewed
Apr 17, 2019
operator/src/main/java/oracle/kubernetes/operator/logging/OncePerMessageLoggingFilter.java
Outdated
Show resolved
Hide resolved
tbarnes-us
approved these changes
Apr 17, 2019
tbarnes-us
reviewed
Apr 17, 2019
operator/src/main/java/oracle/kubernetes/operator/logging/OncePerMessageLoggingFilter.java
Show resolved
Hide resolved
russgold
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents repeated logging of same error messages in periodic invocation of ReadHealthStep by using a new logging filter mechanism that only logs each log message once until ReadHealthStep is successful again. The logging filter remembers what messages were logged and is passed to the Steps via packet.
Also added a few null checks in HttpClient and ReadHealthStep.
Passed jenkins http://****/job/weblogic-kubernetes-operator-javatest/1523