-
Notifications
You must be signed in to change notification settings - Fork 216
OWLS-73314, added tests for monitoring exporter #1068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@marinakog I am not familiar with monitoring exporter, please get the use cases and code reviewed by someone who is familiar. Also, can you make sure these tests would work on remote multi node k8s cluster as well and update USECASES.md. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add more comments inside the code overall.
integration-tests/src/test/java/oracle/kubernetes/operator/utils/TestUtils.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/oracle/kubernetes/operator/utils/TestUtils.java
Outdated
Show resolved
Hide resolved
all tests passed in http://****/job/weblogic-kubernetes-operator-javatest/1633/ except this one : it consistently fails in all of the runs and branches see 1625-1633 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.