Skip to content

OWLS-73314, added tests for monitoring exporter #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 16, 2019
Merged

Conversation

marinakog
Copy link
Member

No description provided.

@vanajamukkara
Copy link
Contributor

vanajamukkara commented May 8, 2019

@marinakog I am not familiar with monitoring exporter, please get the use cases and code reviewed by someone who is familiar. Also, can you make sure these tests would work on remote multi node k8s cluster as well and update USECASES.md.

Copy link
Contributor

@vanajamukkara vanajamukkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more comments inside the code overall.

@marinakog marinakog requested a review from russgold May 8, 2019 22:48
@marinakog marinakog requested a review from rjeberhard May 8, 2019 22:53
@marinakog
Copy link
Member Author

marinakog commented May 8, 2019

all tests passed in http://****/job/weblogic-kubernetes-operator-javatest/1633/

except this one :
ITOperator.testDomainInImageUsingWLST:454 ? Runtime FAILURE: pod domaininimage.

it consistently fails in all of the runs and branches see 1625-1633

@marinakog marinakog requested a review from vanajamukkara May 8, 2019 23:11
Copy link
Contributor

@russgold russgold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjeberhard rjeberhard merged commit 4b5c0b9 into develop May 16, 2019
@rjeberhard rjeberhard deleted the exportertest branch September 6, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants