-
Notifications
You must be signed in to change notification settings - Fork 216
Issue 41 #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 41 #131
Conversation
…general purpose delete-domain.sh script.
The script needs to handle the case where the operator is running. Once you delete the domain resource (assuming the operator is running), the operator will begin shutting down servers and specifically removing the pods, services, and Ingress entries. One option is to work with the operator by editing the domain to set domain.spec.startupControl = "NONE". If the operator is running, then it will shutdown all of the pods gracefully. You can watch the domain.status.conditions array for Progressing and Available conditions. For startupControl = "NONE", the operator will set a condition of type = "Available" and reason = "AllServersStopped". After this, the script could safely delete the domain and other resources. |
…cts, set startupControl on each domain to NONE and wait up to half of max wait seconds for operator to shutdown its WLS pods normally. (2) Increase default max wait seconds to 120 seconds.
This looks really good with maybe one readability comment that getDomain surprised me by getting all of the objects associated with the domain. When it fails intermittently, what happens? |
…edByOperator label to operator owned domain resources, and modify its selectors to look for this label). Plus modify run.sh domain liefecycle test to verify webapp is still OK after a cycling.
… delete logic -- just a small side fix.)
Resolves issue #41 |
Status:
Dev complete and all acceptance tests pass
Changes:
(1) Label domainUid of various k8s resources that weren't already labeled.
(2) Add new weblogic.createdByOperator label for operator created resources, and modify operator code label searches to look for weblogic.createdByOperator in addition to a specific weblogic.domainUid (this prevents operator from changing/deleting/watching resources that it doesn't own).
(3) Add new kubernetes/delete-domain.sh script which takes advantage of labels to delete everything associated with the command-line supplied domain-uid(s). Usage:
Sample run:
Note:
BTW, it turns out Mark had started on a change for this issue via WIP branch issue-41. I discovered this only after I'd written the script and tried to push. So I'm using "issue--41" for this branch instead of "issue-41".