Nginx mii new it #1614
Nginx mii new it #1614
Conversation
…es-operator into nginx-mii-new-it
…es-operator into nginx-mii-new-it
…-kubernetes-operator into nginx-mii-new-it
| private final int replicaCount = 2; | ||
|
|
||
| /** | ||
| * Install operator and Nginx. |
| .and().with().pollInterval(10, SECONDS) | ||
| .atMost(5, MINUTES).await(); | ||
|
|
||
| // get a new unique operator namespace |
There was a problem hiding this comment.
comment and log message don't match what you are doing
| assertNotNull(namespaces.get(1), "Namespace list is null"); | ||
| domainNamespace = namespaces.get(1); | ||
|
|
||
| // get a new unique Nginx namespace |
There was a problem hiding this comment.
spelling - NGINX - will not comment on any more, but this applies to all of them
| // create image with model files | ||
| String miiImage = createImageAndVerify(); | ||
|
|
||
| // push the image to OCIR to make the test work in multi node cluster |
There was a problem hiding this comment.
OCIR -> registry
you don't know it will be OCIR
| logger.info("Check managed server service {0} is created in namespace {1}", | ||
| managedServerPrefix + i, domainNamespace); | ||
| checkServiceCreated(managedServerPrefix + i); | ||
| } |
| } else { | ||
| try { | ||
| // sometimes the pod is not ready even the condition check is ready, sleep a little bit | ||
| Thread.sleep(100); |
There was a problem hiding this comment.
try {
Thread.sleep(100);
} catch (InterruptedException ignore) {
// ignored intentionally
}
| } | ||
| }); | ||
| } catch (Exception e) { | ||
| logger.info("Got exceptions while running command: " + curlCmd); |
| } | ||
| } | ||
|
|
||
| // after the max iterations, check if any managedserver value is false |
| }); | ||
|
|
||
| // final check if any managed server value is false | ||
| return !managedServers.containsValue(false); |
There was a problem hiding this comment.
feels odd to do the same calculation over and over
why not do it once and store the result in a var
| */ | ||
| public static int getNextFreePort(int from, int to) { | ||
| int port; | ||
| for (port = from; port < to; port++) { |
There was a problem hiding this comment.
either fix your javadoc, or use <=
|
This is so far the best test result from Jenkins: |
|
In this run, https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-model-in-image-tests-10/, ItMiiDomain passed. However ItSimpleNginxValidation did not run since NGINX pod stuck in the pending state and BeforeAll failed. |
| } | ||
|
|
||
| // check that NGINX can access the sample apps from all managed servers in the domain | ||
| String curlCmd = String.format("curl --silent --noproxy '*' -H 'host: %s' http://%s:%s/sample-war/index.jsp", |
There was a problem hiding this comment.
using --silent here, when curl fails I think you can't see the error message why its failing by using --silent..use --silent along with --showerror and can you make the curl fail and see if you get the actual error message printed to debug..
| /** | ||
| * Install WebLogic operator and wait until the operator pod is ready. | ||
| */ | ||
| private static void installAndVerifyOperator() { |
There was a problem hiding this comment.
Just to clarify, I am not working on re-organizing the common methods..I will be creating a basic domain image for MII in extension class which can be used by It classes.
| } | ||
| }); | ||
| } catch (Exception e) { | ||
| logger.info("Got exception while running command: " + curlCmd); |
There was a problem hiding this comment.
log error message as well..result.stderr and result.stdout
This PR is to add Nginx ingress controller functionality in new integration test and use Nginx to access the sample apps in the model-in-image domain.