Fix assertion and add events log to the logs list #1619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the persistent volume claim log file name Fix the isPodReady test assertion to check for pod readyness instead of Running status Change the wait time from 5 minutes to 10 minutes
vanajamukkara
approved these changes
May 5, 2020
Yes, I changed the server pods ready check to for pod readiness instead of Running status. Its in TestAssertion.java, line # 98 |
rjeberhard
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add namespaced events in the collected logs list
Fix the persistent volume claim log file name
Fix the isPodReady test assertion to check for pod readiness instead of Running status
Change the domain/operator wait time from 5 to 10 minutes.