OWLS-80960 - Allow replicas count to drop below min dynamic cluster size #1627
Conversation
alai8
requested review from
russgold,
rjeberhard,
tbarnes-us,
rosemarymarano and
lennyphan
docs/domains/Domain.md
Outdated
| @@ -77,6 +77,7 @@ An element representing a cluster in the domain configuration. | |||
|
|
|||
| | Name | Type | Description | | |||
| | --- | --- | --- | | |||
| | `allowReplicasBelowMinDynClusterSize` | Boolean | If true (the default), the number of replicas is allowed to drop below the minimum dynamic cluster size configured in the WebLogic domain home configuration. Otherwise, the operator will ensure that the number of replicas is not below the minimum dynamic cluster. This setting applies to dynamic clusters only. | | |||
There was a problem hiding this comment.
If true (the default), the number -> If true (the default), then the number
that the number of replicas is not below the minimum dynamic cluster -> that the number of replicas is not less than the minimum dynamic cluster setting. OR ->
that the number of replicas is not less than the configured minimum dynamic cluster size.
There was a problem hiding this comment.
Thanks for the comment. I have updated the description to:
If true (the default), then the number of replicas is allowed to drop below the minimum dynamic cluster size configured in the WebLogic domain home configuration. Otherwise, the operator will ensure that the number of replicas is not less than the minimum dynamic cluster setting. This setting applies to dynamic clusters only.
| @@ -1029,6 +1029,10 @@ | |||
| "description": "The name of this cluster. Required", | |||
| "type": "string" | |||
| }, | |||
| "allowReplicasBelowMinDynClusterSize": { | |||
There was a problem hiding this comment.
If true (the default), the number -> If true (the default), then the number
that the number of replicas is not below the minimum dynamic cluster -> that the number of replicas is not less than the minimum dynamic cluster setting. OR ->
that the number of replicas is not less than the configured minimum dynamic cluster size.
| @@ -109,6 +109,10 @@ | |||
| "description": "The name of this cluster. Required", | |||
| "type": "string" | |||
| }, | |||
| "allowReplicasBelowMinDynClusterSize": { | |||
There was a problem hiding this comment.
Should this also be a global setting? On the one hand, it's extra work and I'm not sure if the extra work is worth it at this time. On the other hand, there's precedent where 'replicas' itself is both global and per-cluster.
One way to handle this would be check-in 'as-is' and file a JIRA to add a global setting...
|
This LGTM overall. Made one minor comment above that I don't think is a show stopper. Delegating sign-off to Ryan. |
Introduce a new Cluster CRD element
allowReplicasBelowMinDynClusterSizethat if set to true (the default), the operator would allow replicas count to be set below the minimum dynamic cluster size configured in the WebLogic domain home configuration.This allows users to shut down all servers in a dynamic cluster by setting the cluster replicas count to 0. This also prevents managed servers in a dynamic cluster from starting by operator even if the replicas is 0. This was the behavior before OWLS-79994.
To prevent WLDF from scaling below the min dynamic cluster size, set
allowReplicasBelowMinDynClusterSizeto false.