add integration tests for NAMESPACE_WAITING_STARTED and NAMESPACE_WATCHING_STOPPED events #2322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sankarpn
suggested changes
Apr 21, 2021
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItKubernetesEvents.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItKubernetesEvents.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItKubernetesEvents.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItKubernetesEvents.java
Show resolved
Hide resolved
doxiao
reviewed
Apr 21, 2021
| // check if there is a warning message in operator's log | ||
| String operatorPodName = getOperatorPodName(OPERATOR_RELEASE_NAME, opNamespace); | ||
| String expectedErrorMsg = String.format( | ||
| "Cannot create NamespaceWatchingStopped event in namespace %s due to an authorization error", |
There was a problem hiding this comment.
PR#2323 has changed the log message a little - "Cannot create" -> "Cannot create or replace".
doxiao
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write integration test cases for the function added in owls-86455.
Two events are added: NAMESPACE_WAITING_STARTED and NAMESPACE_WATCHING_STOPPED.
Tested all domainNamespaceSelectionStrategy types that the operator supports
Jenkins result:
https://build.weblogick8s.org:8443/view/all/job/weblogic-kubernetes-operator-kind-new/4778/
https://build.weblogick8s.org:8443/view/all/job/weblogic-kubernetes-operator-kind-new/4777/testReport/