Skip to content

Fix for slim image and domain path #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 13, 2022
Merged

Fix for slim image and domain path #3064

merged 3 commits into from
May 13, 2022

Conversation

sankarpn
Copy link
Member

@sankarpn sankarpn commented May 12, 2022 •
edited
Loading

  • When tests are running with WebLogic slim image the verifyCredentials method has to be passed with adminSvcExtHost parameter if the platform is OKD in integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiDomain.java
  • The integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMultiDomainModels.java had assumeFalse in the test method causing the test to show as Failed when running with slim image. The fix is to skip the test if the test is running with WebLogic slim image.
  • Fix the domain path in the testDataHomeOverrideDomainOnPV() since the domain resource is changed to use a uniquePath

KIND

https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/10599/ (testDataHomeOverrideDomainOnPV)

OKD

https://build.weblogick8s.org:8443/job/wko-okd-test/331/ (if image is slim - ItMultiDomainModels)
https://build.weblogick8s.org:8443/job/wko-okd-test/332/ (if image is full - ItMultiDomainModels)

https://build.weblogick8s.org:8443/job/wko-okd-test/334/ (ItMiiDomain with slim image)
https://build.weblogick8s.org:8443/job/wko-okd-test/334/ (ItMiiDomain with full image)

sankarpn added 3 commits May 12, 2022 08:18
@sankarpn
Fix domain path
d2ed684 
Disable if WEBLOGIC_SLIM image
fix adminCredentialsVerification with adminSvcExtHost set for OKD
@sankarpn
disable test if WEBLOGIC_SLIM system property is true
147cc4e
@sankarpn
use annotations to disable tests on slim image
674d450
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

anpanigr
anpanigr approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@anpanigr anpanigr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

xiancao
xiancao approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@xiancao xiancao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maggiehe00
maggiehe00 approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@maggiehe00 maggiehe00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjeberhard rjeberhard merged commit dd9f7c5 into release/3.4 May 13, 2022
@rjeberhard rjeberhard deleted the altrantest-fix-051222 branch May 13, 2022 00:19
@sankarpn sankarpn mentioned this pull request May 16, 2022
Merged
rjeberhard pushed a commit to rjeberhard/weblogic-kubernetes-operator that referenced this pull request Apr 14, 2023
@sankarpn
Fix for slim image and domain path (oracle#3064)
f683412 
* Fix domain path
Disable if WEBLOGIC_SLIM image
fix adminCredentialsVerification with adminSvcExtHost set for OKD

* disable test if WEBLOGIC_SLIM system property is true

* use annotations to disable tests on slim image
rjeberhard pushed a commit that referenced this pull request Apr 19, 2023
@sankarpn
Fix for slim image and domain path (#3064)
5986320 
* Fix domain path
Disable if WEBLOGIC_SLIM image
fix adminCredentialsVerification with adminSvcExtHost set for OKD

* disable test if WEBLOGIC_SLIM system property is true

* use annotations to disable tests on slim image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@maggiehe00 maggiehe00 maggiehe00 approved these changes

@anpanigr anpanigr anpanigr approved these changes

@xiancao xiancao xiancao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sankarpn @maggiehe00 @anpanigr @xiancao @rjeberhard