integration tests with helm charts #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moreaut
reviewed
Jul 25, 2018
src/integration-tests/bash/run.sh
Outdated
| if [ "$#" != 4 ] ; then | ||
| fail "requires 4 parameters: OP_KEY NAMESPACE TARGET_NAMESPACES EXTERNAL_REST_HTTPSPORT" | ||
| if [ "$#" != 5 ] ; then | ||
| fail "requires 4 parameters: OP_KEY NAMESPACE TARGET_NAMESPACES EXTERNAL_REST_HTTPSPORT SETUP_KUBERNETES_CLUSTER" |
There was a problem hiding this comment.
Typo - should say 'requires 5 parameters'
moreaut
reviewed
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated integration test src/integration-tests/bash/run.sh and cleanup.sh to use helm charts - 1.0 style domain charts and 2.0 style operator helm charts, instead of scripts.
wercker test would still be using install scripts with this change. Will continue to get wercker to work with helm charts in OWLS-67340