OWLS-93551: Changes to expose the server startup properties and add -XX:+CrashOnOutOfMemoryError to JAVA_OPTIONS.
#3706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperties and add `-XX:+CrashOnOutOfMemoryError` to JAVA_OPTIONS.
oracle-contributor-agreement
bot
added
the
OCA Verified
tbarnes-us
reviewed
Nov 30, 2022
|
|
||
| WebLogic Server provides a self-health monitoring feature to improve the reliability and availability of server instances in a domain. If an individual subsystem determines that it can no longer operate consistently and reliably, it registers its health state as `FAILED` with the host server. Each WebLogic Server instance, in turn, checks the health state of its registered subsystems to determine its overall viability. If one or more of its critical subsystems have reached the `FAILED` state, the server instance marks its health state as `FAILED` to indicate that it cannot reliably host an application. | ||
|
|
||
| Using Node Manager, server self-health monitoring enables the automatic restart of the failed server instances. The operator configures the Node Manager to restart the failed server two times within a one-hour interval. It does this by setting the value of the `RestartMax` property (in the [server startup properties](https://docs.oracle.com/en/middleware/fusion-middleware/weblogic-server/12.2.1.4/nodem/java_nodemgr.html#GUID-26475256-2830-434B-B31F-A2D06F48B244) file) to `2` and the value of the `RestartInterval` property to `3600`. You can change the number of times the Node Manager will attempt to restart the server in a given interval by setting the `RESTART_MAX` and `RESTART_INTERVAL` environment variables in the domain resource using the `env` attribute under the `serverPod` element. |
There was a problem hiding this comment.
the failed server two times -> the failed server a maximum of two times
tbarnes-us
reviewed
Nov 30, 2022
| @@ -286,6 +286,7 @@ if [[ "${KUBERNETES_PLATFORM^^}" == "OPENSHIFT" ]]; then | |||
| fi | |||
|
|
|||
| fi | |||
| JAVA_OPTIONS="-XX:+CrashOnOutOfMemoryError $JAVA_OPTIONS" | |||
There was a problem hiding this comment.
I assume this may need an "export"?
There was a problem hiding this comment.
Also, shall we provide a way to remove this "-XX" just in case it has an unancticipated problem? As in something like:
export JAVA_OPTIONS="${JAVA_XX_OPTIONS:--XX:+CrashOnOutOfMemoryError} $JAVA_OPTIONS"
There was a problem hiding this comment.
Good point, changed. Thanks.
rjeberhard
approved these changes
Nov 30, 2022
rosemarymarano
approved these changes
Nov 30, 2022
| @@ -78,6 +78,26 @@ The following operator-populated environment variables are available for use in | |||
|
|
|||
| * A custom liveness probe must not fail (exit non-zero) when the WebLogic Server instance itself is unavailable. This could be the case when the WebLogic Server instance is booting or about to boot. | |||
|
|
|||
| ### Automatic Restart of Failed Server Instances by Node Manager | |||
There was a problem hiding this comment.
Automatic Restart of Failed Server Instances by Node Manager -> Automatic restart of failed server instances by Node Manager
There was a problem hiding this comment.
Changed in a1b5893. Thanks.
tbarnes-us
approved these changes
Nov 30, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
rjeberhard
pushed a commit
to rjeberhard/weblogic-kubernetes-operator
that referenced
this pull request
Apr 14, 2023
…-XX:+CrashOnOutOfMemoryError` to JAVA_OPTIONS. (oracle#3706) * Changes to expose the RestartMax and RestartInterval server startup properties and add `-XX:+CrashOnOutOfMemoryError` to JAVA_OPTIONS.
robertpatrick
pushed a commit
that referenced
this pull request
Apr 26, 2023
…-XX:+CrashOnOutOfMemoryError` to JAVA_OPTIONS. (#3706) * Changes to expose the RestartMax and RestartInterval server startup properties and add `-XX:+CrashOnOutOfMemoryError` to JAVA_OPTIONS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OWLS-93551 - Changes to expose the
RestartMaxandRestartIntervalserver startup properties through environment variables and add-XX:+CrashOnOutOfMemoryErrorto the Node Manager and WebLogic server java command line.Integration test run - https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/14243/