Skip to content

owls-104622 domain status cluster condition Complete type is always True when the cluster replicas changed to 0 #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 14, 2022

Conversation

alai8
Copy link
Member

@alai8 alai8 commented Dec 14, 2022

  • When Cluster resource replicas decreases to 0, Cluster resource Completed condition should remain False until all server pods have completed shutdown.
  • Ensure cluster status is updated after domain status updated successfully
  • Re-enables domain status conditions check in ItRetryImprovementMisc.testClusterReplicasToZero

https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/14650/

@alai8 alai8 requested review from lennyphan and xiancao December 14, 2022 18:13
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 14, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@lennyphan lennyphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjeberhard rjeberhard merged commit 71815de into main Dec 14, 2022
@rjeberhard rjeberhard deleted the owls104622 branch December 14, 2022 22:46
rjeberhard pushed a commit to rjeberhard/weblogic-kubernetes-operator that referenced this pull request Apr 14, 2023
…rue when the cluster replicas changed to 0 (oracle#3754)

* Cluster Completed condition should be False until servers are shut down

* re-enable domain status condition check

* calls createClusterResourceStatusUpdaterStep when doamin stautus update succeeded
robertpatrick pushed a commit that referenced this pull request Apr 26, 2023
…rue when the cluster replicas changed to 0 (#3754)

* Cluster Completed condition should be False until servers are shut down

* re-enable domain status condition check

* calls createClusterResourceStatusUpdaterStep when doamin stautus update succeeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants