Changes to reduce webhook CPU usage. #3870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
rjeberhard
reviewed
Jan 25, 2023
| public PartialObjectMetadata readCustomResourceDefinitionMetadata(String name) { | ||
| HeaderModifierInterceptor.setPartialMetadataHeader(true); | ||
| final PartialObjectMetadata partialObjectMetadata = toPartialObjectMetadata(get(name)); | ||
| HeaderModifierInterceptor.removePartialMetadataHeader(); |
There was a problem hiding this comment.
Suggest putting the remove call in a finally block so that you can't miss removing the interceptor if the call fails.
There was a problem hiding this comment.
Changed in 2e419a7. Thanks.
rjeberhard
approved these changes
Jan 25, 2023
…on test to exclude the cssparser during instrumentation.
…on test to exclude the cssparser during instrumentation.
|
Kudos, SonarCloud Quality Gate passed! |
rjeberhard
pushed a commit
to rjeberhard/weblogic-kubernetes-operator
that referenced
this pull request
Apr 14, 2023
* Changes to reduce webhook CPU usage. Co-authored-by: Russell Gold <russell.gold@oracle.com>
robertpatrick
pushed a commit
that referenced
this pull request
Apr 26, 2023
* Changes to reduce webhook CPU usage. Co-authored-by: Russell Gold <russell.gold@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OWLS-105189 - Changes to reduce webhook CPU usage. This change -
createCRDstep.Integration test runs - https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/15980/
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/15979/
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/15967/