[wko-nightly] Fix the failure from ItMiiClusterResource/testSharedClusterResource to delete shared-cluster #3891
Conversation
…sterResource to delete shared-cluster
oracle-contributor-agreement
bot
added
the
OCA Verified
There was a problem hiding this comment.
The issue found in ItMiiClusterResource/testSharedClusterResource related the fact that "Domain Validation Error " not generated when same cluster resource is associated two domain resources.
How the current change ( delete cluster resource ) will resolve the issue
|
real cause is in https://build.weblogick8s.org:8443/job/wko-kind-nightly-parallel/1212/artifact/logdir/jenkins-wko-kind-nightly-parallel-1212/wl_k8s_test_results/diagnostics/ItMiiClusterResource/testSharedClusterResource/ns-abqknd.list.events.log. The error 1 caused cascade failures, IMO. That's why I started fixing the issue from delete cluster. If it doesn't work down the line, we can look into something else then message: 'Domain domain7 failed due to ''Domain validation error'': Cannot reference message: 'Domain domain7 failed due to ''Internal error'': Cannot invoke "oracle.kubernetes.weblogic.domain.model.DomainResource.isShuttingDown()" message: |- message: 'Cluster domain5-cluster-5 is incomplete for one or more of the following message: 'Domain domain4 failed due to ''Domain validation error'': Cluster resource message: 'Cluster domain9-cluster-2 is incomplete for one or more of the following |
| clusterDoesNotExist(clusterName, CLUSTER_VERSION, namespace), | ||
| getLogger(), | ||
| "cluster {0} to be created in namespace {1}", | ||
| getLogger(), "cluster {0} to be created in namespace {1}", |
There was a problem hiding this comment.
isn't it that the method waits for the cluster to be deleted?
There was a problem hiding this comment.
No Sankar, it doesn't wait:
public static boolean doesClusterExist(String clusterResName, String clusterVersion, String namespace) {
Object clusterObject = null;
try {
clusterObject
= customObjectsApi.getNamespacedCustomObject(
"weblogic.oracle", clusterVersion, namespace, "clusters", clusterResName);
} catch (ApiException apex) {
getLogger().info(apex.getMessage());
}
boolean cluster = (clusterObject != null);
getLogger().info("Cluster Object exists : " + cluster);
return cluster;
}
There was a problem hiding this comment.
Sorry, Sankar. I misunderstood you, Yes. the log msg is wrong. I just changed it
|
Hi Pani, unfortunately we can't, testUntil throws timeout error and doesClusterExist catch the exception itself |
|
Kudos, SonarCloud Quality Gate passed!
|
…sterResource to delete shared-cluster (oracle#3891) * [wko-nightly] Fix the failure from ItMiiClusterResource/testSharedClusterResource to delete shared-cluster
…sterResource to delete shared-cluster (#3891) * [wko-nightly] Fix the failure from ItMiiClusterResource/testSharedClusterResource to delete shared-cluster
the Nightly Failure https://build.weblogick8s.org:8443/job/wko-kind-nightly-parallel/1212/testReport/oracle.weblogic.kubernetes/ItMiiClusterResource/testSharedClusterResource/
error:
message: 'Domain domain7 failed due to ''Domain validation error'': Cannot reference
cluster resource ''shared-cluster'' because it is used by ''domain8''. Update
the domain resource to correct the validation error.'
reason: Failed
we do verify domain/cluster deleted using withStandardRetryPolicy. I can't see any other issue causing the failure of deleting the cluster. We can try to increate the waiting time from withStandardRetryPolicy to withLongRetryPolicy
to make sure we have enough time in case the env is picky
Jenkins:
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/16001/