Skip to content

edited samples/charts READMEs #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2018
Merged

edited samples/charts READMEs #565

merged 1 commit into from
Dec 5, 2018

Conversation

rosemarymarano
Copy link
Contributor

Literary review and edit of README files in the samples/charts directory.

@simon-meng-cn
Copy link
Contributor

Looks good to me.

doxiao
doxiao approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@doxiao doxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rjeberhard rjeberhard merged commit 474368c into develop Dec 5, 2018
@rosemarymarano rosemarymarano deleted the rmarano branch December 5, 2018 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mriccell mriccell Awaiting requested review from mriccell

@simon-meng-cn simon-meng-cn Awaiting requested review from simon-meng-cn

1 more reviewer

@doxiao doxiao doxiao approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@rjeberhard rjeberhard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rosemarymarano @simon-meng-cn @doxiao @rjeberhard