Config overrides site doc #642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
December 14, 2018 01:08
tbarnes-us
requested review from
rjeberhard,
anpanigr,
moreaut,
vanajamukkara,
alai8 and
lennyphan
moreaut
approved these changes
Dec 14, 2018
|
@tbarnes-us I will go ahead and merge this, but please have a look at the user-guide.md and let me know where you think this belongs in the table of contents, so I can add a link. thanks |
alai8
reviewed
Dec 14, 2018
|
It should be 'configOverrides' |
|
@moreaut I keep messing up with that one - I find the name to be confusing, since it refers to a singleton. Thus the original idea of naming it 'configOverrideConfigMap' to make it extremely clear it's a config map, and to make the relation to 'configOverrideSecrets' crystal clear too. |
|
But I guess this confusion isn't enough justification to make such a change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial draft of the config overrides documentation.