Remove run.sh and its mentions #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doxiao
suggested changes
Jan 7, 2019
site/v1.1/README.md
Outdated
| @@ -167,7 +167,7 @@ For information about how to shut down a domain running in Kubernetes, see [Shut | |||
|
|
|||
| To permanently remove the Kubernetes resources for a domain from a Kubernetes cluster, run the [Delete WebLogic domain resources](/kubernetes/delete-weblogic-domain-resources.sh) script. This script will delete a specific domain, or all domains, and all the Kubernetes resources associated with a set of given domains. The script will also attempt a clean shutdown of a domain’s WebLogic pods before deleting its resources. You can run the script in a test mode to show what would be shutdown and deleted without actually performing the shutdowns and deletions. For script help, use its `-h` option. | |||
|
|
|||
| The script will remove only domain-related resources which are labeled with the `domainUID` label, such as resources created by the [Create WebLogic domain](/kubernetes/create-weblogic-domain.sh) script or the [integration tests](/src/integration-tests/bash/run.sh). If you manually created resources and have not labelled them with a `domainUID`, the script will not remove them. One way to label a resource that has already been deployed is: | |||
There was a problem hiding this comment.
I don't think we should remove the references to run.sh from V1.1 doc because run.sh is only removed in V2.0.
There was a problem hiding this comment.
A question: why release V1.1 doc in 2.0 source code?
There was a problem hiding this comment.
@markxnelson @rjeberhard I don't remember the details about this. can you also confirm if my understanding/comments are correct?
There was a problem hiding this comment.
The 1.1 docs were preserved so you could see the documentation for that release. In general, I agree that we should not change the historical documents.
doxiao
requested review from
rjeberhard,
vanajamukkara,
doxiao,
anpanigr and
maggiehe00
tbarnes-us
reviewed
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jenkins passed. http://****/job/weblogic-kubernetes-operator-javatest/801/