READY TO MERGE: Completed JIRA OWLS-71984 - Migrate Session Migration test suite to GitHub #950

hzhao-github · 2019-03-19T00:29:57Z

Created on GitHub the first time

…ithub

integration-tests/src/test/java/oracle/kubernetes/operator/ITSessionMigration.java

integration-tests/src/test/java/oracle/kubernetes/operator/utils/Domain.java

hzhao-github · 2019-03-19T19:43:19Z

Test results:

on Wercker

https://app.wercker.com/Oracle/weblogic-kubernetes-operator/runs/integration-test-java/5c8da4bd23fcb70008d0c4eb?step=5c8da4d903f4460007a652b0

oracle.kubernetes.operator.ITSessionMigration didn't run

on Jenjins

http://****/job/weblogic-kubernetes-operator-javatest/1299/consoleFull

[WARNING] Tests run: 4, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 475.655 s - in oracle.kubernetes.operator.ITSessionMigration

two skipped tests are myTest1 and myTest2 written to reprod the bug 29502819

markxnelson · 2019-03-20T12:46:32Z

you need to push the commit with your changes

hzhao-github · 2019-03-20T22:23:30Z

Pushed my commit

…e war file for web app in a server pod and deploy it from the pod

integration-tests/src/test/java/oracle/kubernetes/operator/ITSessionMigration.java

integration-tests/src/test/java/oracle/kubernetes/operator/utils/TestUtils.java

integration-tests/src/test/resources/apps/buildDeployWebAppInPod.sh

integration-tests/src/test/resources/apps/httpsessionreptestapp/CounterServlet.java

integration-tests/src/test/resources/apps/httpsessionreptestapp/WEB-INF/web.xml

integration-tests/src/test/resources/apps/httpsessionreptestapp/WEB-INF/weblogic.xml

hzhao-github · 2019-03-22T20:09:29Z

Just pushed a new commit with changes to add these missing copyright and javadoc

hzhao-github · 2019-03-22T20:11:19Z

Kicked off run on Jenkins #1350

… file for EJB App in a server pod and deploy it from the pod

markxnelson

looks good

vanajamukkara · 2019-03-25T14:33:09Z

integration-tests/src/test/java/oracle/kubernetes/operator/ITSessionMigration.java

+
+    // Restore test env
+    // Wait some time for ms pod to become ready
+    Thread.sleep(30 * 1000);


sleep 30 secs is not needed here, TestUtils.checkPodReady checks in loop. This adds up test run time. @hzhao-github @anpanigr

agreed. However, if there no any waiting time, the test will start before the pod become ready. Tried 10 seconds but not working.

TestUtils.checkPodReady waits upto 250 seconds for the pod to become ready in loop. which test starts before the pod is ready?

you are right, TestUtils.checkPodReady waits upto 250 seconds, not 50 seconds as I mentioned below. Let me remove the sleep time here. If the test still fails, we need to file a bug for too long for a pod to become ready online

vanajamukkara · 2019-03-25T14:36:13Z

integration-tests/src/test/java/oracle/kubernetes/operator/ITSessionMigration.java

+
+    // Restore test env
+    // Wait some time for ms pod to become ready
+    Thread.sleep(30 * 1000);


sleep 30 secs is not needed here, TestUtils.checkPodReady checks in loop. This adds up test run time. @hzhao-github @anpanigr

agreed. However, if there no any waiting time, the test will start before the pod become ready. Tried 10 seconds butnot working.

Can you explicitly wait for the pod to become ready rather than just a blind 30 seconds? We have code that does this.

Hi Ryan, entire block of that part looks like:

// Restore test env // Wait some time for ms pod to become ready Thread.sleep(30 * 1000); TestUtils.checkPodReady(domainUid + "-" + primaryServName1, domainNS);

TestUtils.checkPodReady waits for 50 seconds for a pod gets ready. Since this test delete the pod, most likely, 50 econds is not long enough for the pod become up and running online again.

How about this, Vanaja if I make this changes:

In BaseTest.java, add a new set method to change

private static int maxIterationsPod = 50;

to a longer time, like maxIterationsPod = 90;

why only 50 seconds? TestUtils.checkPodReady waits upto 250 seconds for the pod to become ready in loop. See below props defined in Operator.props file.

maxIterationsPod=25 waitTimePod=10

I was wrong. Yes, we wait up to 250 seconds :)

integration-tests/src/test/resources/apps/httpsessionreptestapp/CounterServlet.java

integration-tests/src/test/java/oracle/kubernetes/operator/utils/Domain.java

vanajamukkara · 2019-03-25T15:33:08Z

Kicked off run on Jenkins #1350

There are lot of failures in this run, you should sync to the latest develop branch first. Also, post the latest Jenkins run results with these changes.

hzhao-github · 2019-03-25T17:24:04Z

for an unknown reason, "mvn clean verify -P java-integration-tests" failed to me no matter what I do, tried in my local below, both had same set of failures. The failure looks like I didn't get the fix just merged a few days ago. Can you please give advice what I did wrong?

git clone -b develop https://github.com/oracle/weblogic-kubernetes-operator.git
mvn clean verify -P java-integration-tests

git clone -b develop https://github.com/oracle/weblogic-kubernetes-operator.git
mvn clean verify -P java-integration-tests
git checkout session-migration-tests

vanajamukkara · 2019-03-25T17:31:41Z

for an unknown reason, "mvn clean verify -P java-integration-tests" failed to me no matter what I do, tried in my local below, both had same set of failures. The failure looks like I didn't get the fix just merged a few days ago. Can you please give advice what I did wrong?

git clone -b develop https://github.com/oracle/weblogic-kubernetes-operator.git
mvn clean verify -P java-integration-tests

git clone -b develop https://github.com/oracle/weblogic-kubernetes-operator.git
mvn clean verify -P java-integration-tests
git checkout session-migration-tests

You need to get the latest from develop into your branch. Do the following..
git pull origin develop
git status
Resolve the conflicts and merge if any
git add
git commit -m "...."
git push --set-upstream origin session-migration-tests

hzhao-github · 2019-03-25T17:43:20Z

Thanks, Vanaja, I did wrong to sync up with develop :(

hzhao-github · 2019-03-25T17:54:53Z

Vanaja, full steps to sync up with develop branch looks like this, right?

git clone -b session-migration-tests https://github.com/oracle/weblogic-kubernetes-operator.git
cd weblogic-kubernetes-operator
git pull origin develop
git status
Resolve the conflicts and merge if any
git add
git commit -m "...."
git push --set-upstream origin session-migration-tests

…es-operator into session-migration-tests To pull the latest bevelop branch into session-migration-tests branch

hzhao-github · 2019-03-26T00:25:43Z

Eventually get this results :). Let me kick off Jenkins run
[ERROR] Errors:
[ERROR] ITOperator.testDomainOnPVUsingWDT:131->BaseTest.testWLDFScaling:459 ï¿½ Runtime ...
[INFO]
[ERROR] Tests run: 37, Failures: 0, Errors: 1, Skipped: 1

vanajamukkara · 2019-03-26T15:49:19Z

@hzhao-github have you updated README.md with new tests you have added?

…es-operator into session-migration-tests Adding the description to integration-tests

hzhao-github · 2019-03-26T23:26:25Z

got expected results on Jenkins

http://****/job/weblogic-kubernetes-operator-javatest/1376/consoleFull

[INFO]
[ERROR] Errors:
[ERROR] ITOperator.testDomainOnPVUsingWDT:131->BaseTest.testWLDFScaling:458 ? Runtime ...
[INFO]
[ERROR] Tests run: 43, Failures: 0, Errors: 1, Skipped: 1

Completed JIRA OWLS-71984 - Migrate Session Migration test suite to g…

cdeb88c

…ithub

hzhao-github requested review from anpanigr, vanajamukkara and marinakog March 19, 2019 00:30

vanajamukkara reviewed Mar 19, 2019

View reviewed changes

integration-tests/src/test/java/oracle/kubernetes/operator/ITSessionMigration.java Outdated Show resolved Hide resolved

vanajamukkara reviewed Mar 19, 2019

View reviewed changes

integration-tests/src/test/java/oracle/kubernetes/operator/ITSessionMigration.java Outdated Show resolved Hide resolved

vanajamukkara reviewed Mar 19, 2019

View reviewed changes

integration-tests/src/test/java/oracle/kubernetes/operator/ITSessionMigration.java Outdated Show resolved Hide resolved

vanajamukkara reviewed Mar 19, 2019

View reviewed changes

integration-tests/src/test/java/oracle/kubernetes/operator/ITSessionMigration.java Show resolved Hide resolved

markxnelson suggested changes Mar 19, 2019

View reviewed changes

made changes based on comments from co-workers

13aacb9

Completed JIRA OWLS-73084 - QA - Create a generic utility to build th…

1cc7673

…e war file for web app in a server pod and deploy it from the pod

markxnelson suggested changes Mar 22, 2019

View reviewed changes

Added missing copyrights and some javadoc

1d64db5

Completed JIRA OWLS-73106 - Create a generic utility to build the jar…

a37c960

… file for EJB App in a server pod and deploy it from the pod

markxnelson approved these changes Mar 24, 2019

View reviewed changes

jenkins-ignore added missing javadoc

41f07d4

vanajamukkara reviewed Mar 25, 2019

View reviewed changes

integration-tests/src/test/resources/apps/httpsessionreptestapp/CounterServlet.java Outdated Show resolved Hide resolved

vanajamukkara reviewed Mar 25, 2019

View reviewed changes

integration-tests/src/test/java/oracle/kubernetes/operator/utils/Domain.java Show resolved Hide resolved

vanajamukkara reviewed Mar 25, 2019

View reviewed changes

integration-tests/src/test/java/oracle/kubernetes/operator/utils/Domain.java Outdated Show resolved Hide resolved

Merge branch 'develop' of https://github.com/oracle/weblogic-kubernet…

f90c5ad

…es-operator into session-migration-tests To pull the latest bevelop branch into session-migration-tests branch

hzhao-github added 2 commits March 25, 2019 17:34

Synced up with develop branch

c09617a

Synced up with develop branch and remove some comments

d83125b

hzhao-github added 3 commits March 26, 2019 09:07

Merge branch 'develop' of https://github.com/oracle/weblogic-kubernet…

2a439db

…es-operator into session-migration-tests Adding the description to integration-tests

Updated README

82366bd

Syncup README with a merge before me

d8d2535

hzhao-github changed the title ~~WIP: Completed JIRA OWLS-71984 - Migrate Session Migration test suite to GitHub~~ Completed JIRA OWLS-71984 - Migrate Session Migration test suite to GitHub Mar 26, 2019

vanajamukkara approved these changes Mar 26, 2019

View reviewed changes

vanajamukkara changed the title ~~Completed JIRA OWLS-71984 - Migrate Session Migration test suite to GitHub~~ READY TO MERGE: Completed JIRA OWLS-71984 - Migrate Session Migration test suite to GitHub Mar 28, 2019

rjeberhard merged commit e876e1e into develop Mar 28, 2019

rjeberhard deleted the session-migration-tests branch April 9, 2019 12:20

READY TO MERGE: Completed JIRA OWLS-71984 - Migrate Session Migration test suite to GitHub #950

READY TO MERGE: Completed JIRA OWLS-71984 - Migrate Session Migration test suite to GitHub #950

Uh oh!

Conversation

hzhao-github commented Mar 19, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hzhao-github commented Mar 19, 2019 • edited by rjeberhard Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

markxnelson commented Mar 20, 2019

Uh oh!

hzhao-github commented Mar 20, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hzhao-github commented Mar 22, 2019

Uh oh!

hzhao-github commented Mar 22, 2019

Uh oh!

markxnelson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vanajamukkara commented Mar 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hzhao-github commented Mar 25, 2019

Uh oh!

vanajamukkara commented Mar 25, 2019

Uh oh!

hzhao-github commented Mar 25, 2019

Uh oh!

hzhao-github commented Mar 25, 2019

Uh oh!

hzhao-github commented Mar 26, 2019

Uh oh!

vanajamukkara commented Mar 26, 2019

Uh oh!

hzhao-github commented Mar 19, 2019 •

edited by rjeberhard

Loading

vanajamukkara commented Mar 25, 2019 •

edited

Loading

hzhao-github commented Mar 26, 2019 •

edited by rjeberhard

Loading