Skip to content

fix capitalization of 'Docker' in example commands #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2019
Merged

fix capitalization of 'Docker' in example commands #974

merged 1 commit into from
Mar 25, 2019

Conversation

markxnelson
Copy link
Member

This PR fixes the capitalization of "Docker" in example commands where it should be docker not Docker

rosemarymarano
rosemarymarano approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@rosemarymarano rosemarymarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Sorry if I led you astray in my other review. I only meant for you to capitalize Docker when it is used as a product name.)

@markxnelson
Copy link
Member Author

my fault for trusting find & replace !!

@rjeberhard rjeberhard merged commit 8d602f7 into master Mar 25, 2019
@rjeberhard rjeberhard deleted the mark-fix-faq branch April 9, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjeberhard rjeberhard Awaiting requested review from rjeberhard

2 more reviewers

@TheFrogPad TheFrogPad TheFrogPad approved these changes

@rosemarymarano rosemarymarano rosemarymarano approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markxnelson @TheFrogPad @rosemarymarano @rjeberhard