add affinity to domain resource spec #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
rakillen
approved these changes
Aug 5, 2022
robertpatrick
requested changes
Aug 6, 2022
|
|
||
| serverPod.affinity = _getAffinityForServerPod(100); | ||
|
|
||
| return Object.keys(serverPod).length > 0 ? serverPod : null; |
There was a problem hiding this comment.
Why duplicate all the code from _getServerPod() just to add one line? Why not just do something like this?
function getServerPodForCluster(cluster) {
const serverPod = _getServerPod(getJavaOptionsForCluster(cluster), getUserMemArgsForCluster(cluster), getKubernetesResourcesForCluster(cluster)) || {};
const affinity = _getAffinityForServerPod(100);
if (affinity) {
serverPod.affinity = affinity;
}
return Object.keys(serverPod).length > 0 ? serverPod : null;
}
There was a problem hiding this comment.
Server Pod might be empty, and I did not know how to add const serverPod = {}
There was a problem hiding this comment.
resolved code per suggestions
robertpatrick
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Jira #355