Skip to content

short-circuiting prepare model when domain is in PV #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2021
Merged

short-circuiting prepare model when domain is in PV #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions electron/app/locales/en/webui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,6 +675,7 @@
"discover-dialog-online-discovery-failed-error-prefix": "Unable to discover domain {{adminUrl}} in online mode",

"wdt-preparer-aborted-error-title": "Prepare Model Aborted",
"wdt-preparer-domain-in-pv-message": "Prepare Model has no meaning when the target domain location is an externally created Kubernetes persistent volume.",
"wdt-preparer-invalid-java-home-error-prefix": "Unable to prepare model due to the Java Home being invalid",
"wdt-preparer-invalid-oracle-home-error-prefix": "Unable to prepare model due to the Oracle Home being invalid",
"wdt-preparer-project-not-saved-error-prefix": "Unable to prepare model because project save failed",
Expand Down
6 changes: 6 additions & 0 deletions webui/src/js/utils/wdt-preparer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ function(project, wktConsole, i18n, projectIo, dialogHelper, validationHelper, w
}

let errTitle = i18n.t('wdt-preparer-aborted-error-title');
if (this.project.settings.targetDomainLocation.value === 'pv') {
const errMessage = i18n.t('wdt-preparer-domain-in-pv-message');
await window.api.ipc.invoke('show-info-message', errTitle, errMessage);
return Promise.resolve(false);
}

const validationObject = this.getValidationObject('flow-prepare-model-name');
if (validationObject.hasValidationErrors()) {
const validationErrorDialogConfig = validationObject.getValidationErrorDialogConfig(errTitle);
Expand Down