Buttons without accessible names

[kdva-code]

🏷️ Discussion Type

Bug

💬 Feature/Topic Area

Actions

Body

Buttons without accessible names

I noticed that some buttons rely only on icons, without an accessible name.

For example:

<button onClick={toggleMenu}>
  <MenuIcon />
</button>

Screen readers may announce this as just "button", which isn't very helpful.

Wouldn't it be better to add an aria-label?

<button onClick={toggleMenu} aria-label="Open menu">
  <MenuIcon />
</button>

It's a small detail, but I think it's easy to overlook during UI development.

Do you usually check these things manually or rely on tools like Lighthouse and axe?

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐

[hexjasur]

yeah i agree this is easy to miss when building custom UI components

i usually try to add aria labels to icon only buttons from the beginning

lighthouse and axe are useful but they dont catch every accessibility issue so manual testing with a screen reader is still worth doing