Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#211 declared Tree.getChain as factory #212

Merged
merged 1 commit into from
Feb 3, 2020
Merged

#211 declared Tree.getChain as factory #212

merged 1 commit into from
Feb 3, 2020

Conversation

mag-sruehl
Copy link
Contributor

Fixed the memory leak described in #211

@mag-sruehl mag-sruehl mentioned this pull request Jan 30, 2020
Closed
MatthijsBurgh
MatthijsBurgh approved these changes Feb 3, 2020
View reviewed changes
Copy link
Collaborator

@MatthijsBurgh MatthijsBurgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indeed requires a Factory annotation as a new instance is returned.

@mag-sruehl mag-sruehl requested a review from smits February 3, 2020 10:18
@smits smits merged commit 3053a12 into orocos:master Feb 3, 2020
@mag-sruehl mag-sruehl deleted the fix/211/get-chain-mem-leak branch February 4, 2020 09:43
@jspricke jspricke mentioned this pull request Apr 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smits smits smits approved these changes

@MatthijsBurgh MatthijsBurgh MatthijsBurgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mag-sruehl @smits @MatthijsBurgh