Merge pull request #178 from orxfun/make-NodeIdx-Send

Make node idx send

Author: orxfun

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "orx-tree"
-version = "1.11.0"
+version = "2.0.0"
 edition = "2024"
 authors = ["orxfun <orx.ugur.arikan@gmail.com>"]
 description = "A beautiful tree 🌳 with convenient, efficient, parallelizable growth, mutation and traversal features."
@@ -17,7 +17,7 @@ orx-self-or = "1.2.0"
 serde = { version = "1.0.228", optional = true, default-features = false }
 orx-pinned-vec = { version = "3.21.0", default-features = false }
 orx-split-vec = { version = "3.22.0", default-features = false }
-orx-selfref-col = { version = "2.15.0", default-features = false }
+orx-selfref-col = { version = "3.0.0", default-features = false }
 orx-concurrent-iter = { version = "3.1.0", default-features = false }
 orx-parallel = { version = "3.3.0", default-features = false, optional = true }
 

README.md

@@ -9,7 +9,7 @@ fn build_tree(n: usize) -> DynTree<String> {
     while tree.len() < n {
         let root = tree.root();
         let x: Vec<_> = root.leaves_with(&mut dfs).map(|x| x.idx()).collect();
-        for idx in x.iter() {
+        for idx in x {
             let count = tree.len();
             let mut node = tree.node_mut(idx);
             let num_children = 4;

benches/children_iterator.rs

@@ -10,7 +10,7 @@ fn build_tree(n: usize) -> DynTree<String> {
     while tree.len() < n {
         let root = tree.root();
         let x: Vec<_> = root.leaves_with(&mut dfs).map(|x| x.idx()).collect();
-        for idx in x.iter() {
+        for idx in x {
             let count = tree.len();
             let mut node = tree.node_mut(idx);
             let num_children = 20;

benches/parallelization_owned.rs

@@ -10,7 +10,7 @@ fn build_tree(n: usize) -> DynTree<String> {
     while tree.len() < n {
         let root = tree.root();
         let x: Vec<_> = root.leaves_with(&mut dfs).map(|x| x.idx()).collect();
-        for idx in x.iter() {
+        for idx in x {
             let count = tree.len();
             let mut node = tree.node_mut(idx);
             let num_children = 20;

benches/parallelization_ref.rs

@@ -10,7 +10,7 @@ fn build_tree(n: usize) -> DynTree<String> {
     while tree.len() < n {
         let root = tree.root();
         let x: Vec<_> = root.leaves_with(&mut dfs).map(|x| x.idx()).collect();
-        for idx in x.iter() {
+        for idx in x {
             let count = tree.len();
             let mut node = tree.node_mut(idx);
             let num_children = 4;

benches/paths_iterator.rs

@@ -10,7 +10,7 @@ fn build_tree(n: usize) -> DynTree<String> {
     while tree.len() < n {
         let root = tree.root();
         let x: Vec<_> = root.leaves_with(&mut dfs).map(|x| x.idx()).collect();
-        for idx in x.iter() {
+        for idx in x {
             let count = tree.len();
             let mut node = tree.node_mut(idx);
             let num_children = 10;

benches/walk_iterator.rs

@@ -39,7 +39,7 @@ fn build_tree(total_depth: usize) -> DaryTree<4, usize> {
         let leaves: Vec<_> = root.leaves_with(&mut dfs).map(|x| x.idx()).collect();
         for idx in leaves {
             let count = tree.len();
-            let mut node = tree.node_mut(&idx);
+            let mut node = tree.node_mut(idx);
             for j in 0..4 {
                 node.push_child(count + j);
             }

examples/bench_parallelization.rs

@@ -11,7 +11,7 @@ fn build_tree(total_depth: usize, num_children: usize) -> DynTree<String> {
         let leaves: Vec<_> = root.leaves_with(&mut dfs).map(|x| x.idx()).collect();
         for idx in leaves {
             let count = tree.len();
-            let mut node = tree.node_mut(&idx);
+            let mut node = tree.node_mut(idx);
             for j in 0..num_children {
                 node.push_child((count + j).to_string());
             }

examples/demo_parallelization.rs

@@ -71,9 +71,9 @@ impl Instructions {
             InstructionNode::new(Instruction::AddI { val: 2.0 }, 0.0),
         ]);
         let _n3 = tree
-            .node_mut(&n1)
+            .node_mut(n1)
             .push_child(InstructionNode::new(Instruction::Input(0), 0.0));
-        let [_n4, _n5] = tree.node_mut(&n2).push_children([
+        let [_n4, _n5] = tree.node_mut(n2).push_children([
             InstructionNode::new(Instruction::Add, 0.0),
             InstructionNode::new(Instruction::AddI { val: 5.0 }, 0.0),
         ]);
@@ -153,15 +153,15 @@ fn recursive_traversal_over_indices(
     inputs: &[f32],
     node_idx: NodeIdx<Dyn<InstructionNode>>,
 ) -> f32 {
-    let node = tree.node(&node_idx);
+    let node = tree.node(node_idx);
 
     let children_ids: Vec<_> = node.children().map(|child| child.idx()).collect();
     let children: Vec<_> = children_ids
         .into_iter()
         .map(|node| recursive_traversal_over_indices(tree, inputs, node))
         .collect();
 
-    let mut node = tree.node_mut(&node_idx);
+    let mut node = tree.node_mut(node_idx);
 
     let new_value = match node.data().instruction {
         Instruction::Input(i) => inputs[i],