Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Prettier configuration into a config file #155

Closed
kevgo opened this issue May 21, 2019 · 2 comments
Closed

Extract Prettier configuration into a config file #155

kevgo opened this issue May 21, 2019 · 2 comments

Comments

@kevgo
Copy link
Contributor

kevgo commented May 21, 2019

problem

The Prettier options to format the documentation (proseWrap: always, single-quote, etc) are hardcoded into the format NPM script.

proposed solution

Extract the Prettier options into a Prettier configuration file.

advantages

  • auto-formatters embedded in IDEs (for example Prettier for VSCode) and auto-format bots can find and use the Prettier options
  • the same Prettier options are used throughout the code base
  • calling Prettier manually still uses the right config options
@aeneasr
Copy link
Member

aeneasr commented May 22, 2019

SGTM

@kevgo
Copy link
Contributor Author

kevgo commented Jun 3, 2019

Implemented in #160

@kevgo kevgo closed this as completed Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevgo @aeneasr