Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Prettier config into prettierrc #160

Merged
merged 6 commits into from
May 23, 2019
Merged

Extract Prettier config into prettierrc #160

merged 6 commits into from
May 23, 2019

Conversation

kevgo
Copy link
Contributor

@kevgo kevgo commented May 22, 2019

I made it in JSON because I know you don't like YML :)

It somehow also re-formatted a bunch of MD files, which looks legit.
No content changes have been made except Prettier changing double-quotes to single-quotes in the code blocks inside Markdown.

I have removed the printWidth option because the default is already 80 characters.

@CLAassistant
Copy link

CLAassistant commented May 22, 2019

CLA assistant check
All committers have signed the CLA.

@kevgo
Copy link
Contributor Author

kevgo commented May 22, 2019

Hmm, our friend prettifier[bot] cannot sign this since he has no hands... I own it. Can I sign instead? Or can you whitelist it?

@aeneasr
Copy link
Member

aeneasr commented May 23, 2019

That's pretty cool (the bot!). Does that exist for go etc too? Also, do I need to install it for this repo separately?

@aeneasr aeneasr merged commit dcdb845 into ory:master May 23, 2019
@kevgo
Copy link
Contributor Author

kevgo commented May 24, 2019

Cool, I'm glad you like it! Right now it's a prototype that only runs Prettier. But it's certainly possible to add support for other languages, that's a great idea! I'll have to see when I get to it since currently I'm pretty much traveling the entire time.

@kevgo
Copy link
Contributor Author

kevgo commented May 24, 2019

Yes, you have to give Prettifier access to your repos. Either for all repos in your Github org, or just a list of them.

@kevgo kevgo deleted the kg-prettierrc branch May 24, 2019 11:46
@aeneasr
Copy link
Member

aeneasr commented May 24, 2019

Oh I didn't see that you wrote that! Very cool, 10/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants