Skip to content

feat: add documentation for Salesforce setup #1797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 31, 2024

Conversation

IchordeDionysos
Copy link
Contributor

@IchordeDionysos IchordeDionysos commented Jul 18, 2024

Add documentation on how to setup Salesforce SSO integrations.

Related Issue or Design Document

ory/kratos#3984
ory/kratos#4003

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@IchordeDionysos IchordeDionysos changed the title Add documentation for Salesforce setup feat: add documentation for Salesforce setup Jul 18, 2024
vinckr
vinckr previously approved these changes Jul 19, 2024
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great contribution, thanks!
I haven't tested it out as I dont have Salesforce set up, but I assume that has been done in the /kratos PR.

@IchordeDionysos
Copy link
Contributor Author

IchordeDionysos commented Jul 19, 2024

Some screenshots detailing the flow (for posterity sake) :)

image image image image image image image image

@IchordeDionysos
Copy link
Contributor Author

@vinckr yes, just tested the setup with the documentation again from scratch and found one detail with PKCE and added it to the documentation.

See also the screenshots how it looks.
I wouldn't add them to the documentation but having them here might be useful for someone :)

vinckr
vinckr previously approved these changes Jul 19, 2024
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for the addition @IchordeDionysos!

I wonder if we can make use of the screenshots somehow, but I agree that they probably are outdated soon 🤔

@IchordeDionysos
Copy link
Contributor Author

Hmm maybe we could add this screenshot (as selecting the scopes is a bit strange and to compare the exact OAuth configuration):
image
Maybe we could cut of the basic information as it doesn't bring too much value

And this image as it's less obvious where to get the client ID/secret from:
image

@vinckr vinckr merged commit 27aad66 into ory:master Jul 31, 2024
8 checks passed
@IchordeDionysos IchordeDionysos deleted the patch-1 branch July 31, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants