Skip to content

chore: update docs for CAPTCHAs #2021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

pcaillaudm
Copy link
Contributor

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@christiannwamba christiannwamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@vinckr
Copy link
Member

vinckr commented Feb 17, 2025

Tbh I would prefer for this to be in a dedicated document on how to configure CAPTCHA - since the document you added it to is just talking about concepts of security on a high level and does not provide any instructions on how to configure things.
I think a more appropriate place would be for example under Guides -> Operations.

But I will leave it up to @christiannwamba to decide - if urgent we can also merge it as is and later on move it to a more appropriate place.

Copy link
Collaborator

@piotrmsc piotrmsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when we add support for other providers for captchas I think dedicated document will make a lot of sense, for now it's fine with small update as added.

@vinckr vinckr changed the title chore: update docs for CAPCTHAs chore: update docs for CAPTCHAs Feb 21, 2025
@vinckr vinckr enabled auto-merge (squash) February 21, 2025 15:26
@vinckr vinckr merged commit b3facab into ory:master Feb 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants