Skip to content

Conversation

jonas-jonas
Copy link
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas
Copy link
Member Author

Screen.Recording.2025-06-24.at.4.38.36.PM.mov

@aeneasr
Copy link
Member

aeneasr commented Jun 25, 2025

Wow, that's really cool! Let's merge this as is and maybe @jfcurran or @ricardo-osorio-santos can give this a bit of styling later in the quarter.

@jonas-jonas
Copy link
Member Author

@aeneasr good to go from my side!

@jfcurran
Copy link
Member

jfcurran commented Jul 2, 2025

this is quite cool Jonas!

is the intention to keep (and maintain) the mermaids or can we use pngs instead?

  • pngs are easier to style
  • mermaids are easier to maintain

I see the value in both – Jonas, what's your preference here? ideally I would simply proivide a theme to style all of mermaid.js, across the entire docs

@jonas-jonas
Copy link
Member Author

I'd like to keep mermaid, because their source is just text and they can be adjusted as needed. PNGs go out of date and adjusting them is a pain (see the current version).

Also the interactive version as built here relies heavily on mermaid, so it's not possible to use pngs here, anyway.

@jfcurran
Copy link
Member

jfcurran commented Jul 2, 2025

agreed - I'll look into providing a theme for mermaid 👍

@jonas-jonas jonas-jonas merged commit e83260a into master Jul 2, 2025
9 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/interactiveProjectCharts branch July 2, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants