Skip to content

Conversation

gaultier
Copy link
Contributor

@gaultier gaultier commented Jul 8, 2025

Related Issue or Design Document

https://github.com/ory-corp/cloud/pull/8826

@gaultier gaultier requested a review from jonas-jonas July 8, 2025 14:28
@gaultier gaultier enabled auto-merge (squash) July 10, 2025 09:05
@gaultier gaultier requested review from hperl and jonas-jonas July 10, 2025 09:06
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please always look at the preview, the "Download your current configuration" is not rendered for some reason

edit2: ah nevermind I was just confused.
Maybe we should increment the headings for CLI so they don't show up in the table of contents on the right.
its a classic problem with tabs in docusaurus

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

the feature flag is not yet available in settings right @gaultier ?

Did you also check if http://ory.sh/docs/kratos/self-service/flows/account-recovery-password-reset needs an update? That is the main concept doc for recovery, the other one is "just" the quickstart.

@gaultier
Copy link
Contributor Author

gaultier commented Jul 11, 2025

lgtm.

the feature flag is not yet available in settings right @gaultier ?

On master as of now, the feature flag is present including in the UI, but it does not yet do anything. When https://github.com/ory-corp/cloud/pull/8826 is merged, it will do what is described in the docs.

Did you also check if http://ory.sh/docs/kratos/self-service/flows/account-recovery-password-reset needs an update? That is the main concept doc for recovery, the other one is "just" the quickstart.

I have just added a section on the main account recovery page, even though it is a bit redundant, it is still better as you mentioned.

@gaultier gaultier dismissed jonas-jonas’s stale review July 11, 2025 12:47

Addressed changes

@gaultier gaultier merged commit ab617e0 into master Jul 11, 2025
8 checks passed
@gaultier gaultier deleted the pgaultier-recovery-v2 branch July 11, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants