Skip to content

Conversation

leecalcote
Copy link

@leecalcote leecalcote commented Aug 14, 2025

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @leecalcote,
can you help me understand this change?

at the moment this results in the brew install ory/tap/cli command which is correct, your change results in brew install ory/tap/ory which is not correct.

let me know what you were trying to achieve here please :)

@vinckr
Copy link
Member

vinckr commented Aug 15, 2025

ah nevermind I see what you were trying to achieve - the current snippet results in the wrong command to test the installation "cli help"...

@vinckr
Copy link
Member

vinckr commented Aug 15, 2025

I added a fix for this here - #2276 - thanks for your PR @leecalcote; I will close this now since it needed some changes on the component itself.

@vinckr vinckr closed this Aug 15, 2025
Copy link
Contributor

@unatasha8 unatasha8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants