feat: Configure Permission Service using CLI guide #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepatrik
commented
Jun 13, 2022
docs/guides/cli/basics.mdx
Outdated
| @@ -1,6 +1,7 @@ | |||
| --- | |||
| id: cli-basics | |||
| title: Basic Functionality | |||
| sidebar_position: 5 | |||
There was a problem hiding this comment.
Changing file content is better to review than changing file names IMO. I can also revert this, but we did not use the number convention elsewhere so this is also more consistent.
There was a problem hiding this comment.
Changing filenames broke two relative links which causes the website build to fail. Logs:
Error: Docs markdown link couldn't be resolved: (../guides/cli/10_config-with-cli.mdx) in /docs/docs/concepts/personal-access-token.mdx for version current
at Array.forEach (<anonymous>)
Error: Docs markdown link couldn't be resolved: (./cli/20_proxy-and-tunnel.mdx) in /docs/docs/guides/custom-domains.mdx for version current
at Array.forEach (<anonymous>)
There was a problem hiding this comment.
The system where the document order is determined by filenames is something I'm trying out and I really like it so far. The benefits are:
- the
sidebarsfile is leaner - you can see the correlation between the left navigation and the files in the directory at the first glance
- when you start messing with the file order you don't have to open any other files to know what to do - everything is visible at a glance without having to inspect the metadata section of the docs
I'm slowly implementing this system as I update/refactor/create new documents. For know, I think that this is the way to go.
Please revert filenames to their initial state. This will fix your failing build.
| @@ -54,7 +55,7 @@ ory get identity-config <project-id> --format yaml > identity-config.yaml | |||
|
|
|||
| ## Import Configuration to Ory Cloud | |||
|
|
|||
| To start using using the configuration from a self-hosted Ory Kratos instance in the Ory Cloud Identity Service, import the | |||
| To start using the configuration from a self-hosted Ory Kratos instance in the Ory Cloud Identity Service, import the | |||
tomekpapiernik
suggested changes
Jun 13, 2022
zepatrik
force-pushed
the
feat/permission-config
branch
from
ee9f840 to
f81561e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/ory-corp/cloud/issues/2522